Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
Collaborator
|
Support for the new Feedback APIs was added here: The original PR has two different overloads: Another overload allowing for a ConfigureScope parameter was added in this PR: |
Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
Member
Author
|
Thanks James |
jamescrosswell
approved these changes
May 23, 2025
antonpirker
pushed a commit
that referenced
this pull request
Jun 6, 2025
We should do a rename on all of the docs for `CaptureUserFeedback` since the API is deprecated. @jamescrosswell does this overload exist? I quickly looked the API and it takes `UserFeedback` as an argument. Calling `CaptureFeedback(new Feedback` is pretty cumbersome --------- Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should do a rename on all of the docs for
CaptureUserFeedbacksince the API is deprecated.@jamescrosswell does this overload exist? I quickly looked the API and it takes
UserFeedbackas an argument.Calling
CaptureFeedback(new Feedbackis pretty cumbersome